Skip to content

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Aug 15, 2019

Fixes #683

Description of the Change

Because of star import linting didn't realize that ObjectDoesNotExist exception was not properly imported.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk August 15, 2019 18:15
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #690 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   95.96%   95.97%   +0.01%     
==========================================
  Files          54       54              
  Lines        2727     2735       +8     
==========================================
+ Hits         2617     2625       +8     
  Misses        110      110
Impacted Files Coverage Δ
example/tests/test_serializers.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92aabaf...6ce38f5. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1fa7deb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #690   +/-   ##
=========================================
  Coverage          ?   95.97%           
=========================================
  Files             ?       54           
  Lines             ?     2735           
  Branches          ?        0           
=========================================
  Hits              ?     2625           
  Misses            ?      110           
  Partials          ?        0
Impacted Files Coverage Δ
example/tests/test_serializers.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa7deb...83dd124. Read the comment docs.

@sliverc
Copy link
Member Author

sliverc commented Aug 21, 2019

@n2ygk Could you have a look at this PR? Thanks.

@n2ygk
Copy link
Contributor

n2ygk commented Aug 21, 2019

@n2ygk Could you have a look at this PR? Thanks.

@sliverc Will do. Sometimes I miss these assignment emails because I subscribe to all activity. I'll make a tickler to regularly check https://github.com/pulls/review-requested

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good. Sorry for the delay in reviewing this.

@n2ygk n2ygk merged commit bd8b535 into django-json-api:master Aug 21, 2019
@sliverc sliverc deleted the does_not_exist branch December 28, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants