Fixed #31380 -- Added deployment system check for DJANGO_ALLOW_ASYNC_UNSAFE environment variable.

[hashlash]

https://code.djangoproject.com/ticket/31380

[hashlash]

After doing some research I've found some alternative for async reserved word used by some open-source projects:

• async_: tools: python3 compat for inspector code generator nodejs/node#29340
• async_val: Adding aliases for field attributes and renaming async attribute ansible/ansible#33141
• asynchronous: python3.7 support Miserlou/Zappa#1762 Backport Python 3 async fixes (and shadow fix) saltstack/salt#51533 Py37 migration pymodbus-dev/pymodbus#321

From those alternatives, I think the most appropriate is asynchronous. The only drawback I can think of is its verbosity (and word length).

• async_: I think it's more appropriate on local variables

• async_val: consist of two words and what we want is not just any regular 'value'

• async_safety (proposed in here): same as async_val, and the word length is similar with asynchronous

• asgi (from this comment): argument from @andrewgodwin:

  ... but asgi is sort of misleading, this happens under synchronous environments too

[adamchainz]

I'm slightly against async_safety since the tag should be general purpose enough for use with multiple checks. There could be other async related checks that aren't for "safety" purposes necessarily, but performance, library compatibility etc. But if it's the best then we can go for it.

I'm also slightly against asynchronous since it's an adjective not a noun, and all the other tags are nouns. The correct noun would be asychronicity but I just struggled to spell that even.

I'm still fine with on async_. The string for display can still be without the trailing underscore. We can understand it as short for asynchronicity or async def or whatever.

Fine with async_val, or other combinations like async_usage, async_compatibility, etc.

Don't want to bikeshed.

[adamchainz]

Great work @hashlash

[hashlash]

I just realized that the models tagged system check module is named model_checks, so I rename the module to async_checks

[adamchainz]

I've come back and reviewed this again, looking good. I've made a few more edits. I would push them to your branch so you don't have to do anything but since DEP009 github won't let anyone but fellows do that.

Here's a patch - can you apply it please? :)

patch.txt

[hashlash]

Thanks for the guidance @adamchainz! Will do it right away

[adamchainz]

Just realized my patch file was in reverse, sorry!

Looking good apart from a couple things missed because patch files aren't perfect.

[felixxm]

@hashlash Thanks 👍 Welcome aboard ⛵

I pushed minor edits.

[adamchainz]

[hashlash]

@hashlash Thanks Welcome aboard

You're welcome! It's nice to be able to contribute 😄