Py37 migration #321
Closed
Py37 migration #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbergmiller thanks for the quick PR, could you also add python3.7 to travis.yml so that the tests are run and tested on python 3.7 as well ? Thanks |
|
@cbergmiller Tests are failing |
|
@dhoomakethu The tests are failing at the Twisted client, which i didn't touch. And tests pass in my Windows environment. I will look into it. |
|
@cbergmiller , quoting from this conversation #337 (comment). Would you mind raising this PR against |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed fix for #320