patch to use function objects in python views

[djc]

From adam.kocoloski@gmail.com on December 22, 2008 06:08:39

Hi, I think it'd be useful if the TemporaryView and ViewDefinition classes could accept function
objects for the map and reduce phases of a Python view. I'm attaching a patch that uses
inspect.getsource() to accomplish this. Best,

Adam

Attachment: couchdb-python.diff

Original issue: http://code.google.com/p/couchdb-python/issues/detail?id=44

[djc]

From randall....@gmail.com on February 27, 2009 20:48:57

adam, thanks for your patch.
Unfortunately, there is a problem with the patch as it is.
inspect.getsource() only works for a function which is defined in a source file on
disk and just because isinstance(fun, FunctionType) is true doesn't mean getsource()
won't throw an exception.

However, I can't imagine a situation where practically speaking one would pass a
function object that wasn't from a source file. If you had the raw code to begin with
you could just pass it along without compiling it to a function object.

I'm accepting this and assigning it to myself. I'll play around with it.

In the meantime, a workaround if you want to run views which are defined in .py files
is to install your .py files into your python library for the environment the view
server runs in and pass the string "from module import map_fun" for the map function.

Status: Accepted
Owner: randall.leeds
Labels: -Type-Defect Type-Enhancement

[djc]

From cmlenz on February 28, 2009 04:18:25

Randall, I have this patch integrated in my working copy already, and have even added some decorator fu. I'll
check in after some more testing.

Owner: cmlenz

[djc]

From cmlenz on March 09, 2009 14:39:49

Patch plus decorator support checked in in r136 .

Status: Fixed