Prettier wanted some changes on my machine. #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But Travis said the previous version was ok. What's going on?
|
@talwrii Travis didn't seem to be running things correctly. When I got eslint running it didn't like a couple of things so I had to do some rearranging to avoid the non-null-assertions. See what you think. |
|
Yeah that's just a relic of my hacking. The URLs were actually hard-coded in |
|
Does it work now? I'd have to actually run up the Coniql server. I would like more unit tests instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But Travis said the previous version was ok. What's going on?