Making sizes in web more similar to sizes in CS-Studio, by subtractin… #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a fixed value from the size received from the synoptic.opi
|
I should add that I don't like having to subtract 5 pixels like this, but the slightly more complicated design of the LED in CS-Studio means the sizes are out of sync. In CS-Studio the LED has a small border that transitions between the LED and the background (and causes this size discrepancy), which is on my TODO list to implement so I don't have to subtract these 5 pixels like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor update, to make the LED in the web look more similar to the size in CS-Studio, a fixed value of 5 pixels is subtracted from the value received from the .opi file. Tests have then been updated.