Making gdbn an extra require #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
|
Thanks for creating this PR! It would be really nice to get nolearn on conda-forge without the gdbn req, which has been a pain. It seems that there's a simple error in the setup.py, which is causing the builds to fail |
|
I don’t know about any setup.py dev - should that work? I don’t think I changed anything that would change that original test. |
|
Actually, you might want to try just re-running the builds. |
|
okay just updated with master and new push. |
|
All green! 🍏 💚 |
|
Great! Once the updates are on pypi, I'll create the conda-forge recipe |
|
@dnouri let us know if any additional changes are needed. |
|
Thanks for your work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggested fix for #335 - we just make gdbn an extra require so the core package can be installed without it.
Signed-off-by: Vanessa Sochat vsochat@stanford.edu