Skip to content

Commit 04d3e87

Browse files
committed
test: ✅ corrige les warnings dans les tests Vitest
Résout #1229 Les tests généraient plusieurs warnings Vue qui polluaient la sortie : - Ajout de la prop requise `value` dans DsfrCheckbox.spec.ts - Ajout de la prop requise `label` dans DsfrMultiselect.spec.ts (6 tests) - Ajout de la prop `titleLinkAttrs` dans DsfrCard.spec.ts - Suppression des console.log dans DsfrSelect.spec.ts Tous les tests passent maintenant sans warnings. fixes #1229
1 parent 62ba092 commit 04d3e87

File tree

8 files changed

+21
-16
lines changed

8 files changed

+21
-16
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
"@gouvfr/dsfr": "~1.14.2",
9090
"focus-trap": "^7.6.4",
9191
"focus-trap-vue": "^4.0.3",
92-
"vue": "^3.5.13",
92+
"vue": "^3.5.25",
9393
"vue-router": "^4.5.0"
9494
},
9595
"devDependencies": {
@@ -154,7 +154,7 @@
154154
"vite-node": "^3.0.5",
155155
"vite-plugin-full-reload": "^1.2.0",
156156
"vitepress": "^1.6.3",
157-
"vitest": "^3.0.5",
157+
"vitest": "^3.2.4",
158158
"vue-demi": "^0.14.10",
159159
"vue-tsc": "^2.2.0"
160160
},

src/components/DsfrAccordion/DsfrAccordion.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const {
3636
3737
const isStandaloneActive = ref()
3838
39-
const useAccordion = inject(registerAccordionKey)!
39+
const useAccordion = inject(registerAccordionKey, undefined)!
4040
const { isActive, expand } = useAccordion?.(toRef(() => props.title)) ?? { isActive: isStandaloneActive, expand: () => isStandaloneActive.value = !isStandaloneActive.value }
4141
4242
onMounted(() => {

src/components/DsfrCard/DsfrCard.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ describe('DsfrCard', () => {
5454
},
5555
},
5656
props: {
57+
titleLinkAttrs: {},
5758
altImg,
5859
detail,
5960
title,

src/components/DsfrCheckbox/DsfrCheckbox.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ describe('DsfrCheckbox', () => {
1919
},
2020
},
2121
props: {
22+
value: 1,
2223
label,
2324
modelValue,
2425
name: 'label-1',
@@ -54,6 +55,7 @@ describe('DsfrCheckbox', () => {
5455
},
5556
},
5657
props: {
58+
value: 1,
5759
label,
5860
modelValue,
5961
name: 'label-1',

src/components/DsfrMultiselect/DsfrMultiselect.spec.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ describe('DsfrMultiselect', () => {
1717
// When
1818
const { getByRole, getAllByRole } = render(DsfrMultiselect, {
1919
props: {
20+
label: 'Test multiselect',
2021
modelValue: values,
2122
options,
2223
},
@@ -44,6 +45,7 @@ describe('DsfrMultiselect', () => {
4445
// When
4546
const { getByRole, getAllByRole } = render(DsfrMultiselect, {
4647
props: {
48+
label: 'Test multiselect avec options sélectionnées',
4749
modelValue: values,
4850
options,
4951
},
@@ -73,6 +75,7 @@ describe('DsfrMultiselect', () => {
7375
// When
7476
const { getByRole, getAllByRole } = render(DsfrMultiselect, {
7577
props: {
78+
label: 'Test multiselect avec recherche',
7679
modelValue: values,
7780
options,
7881
search: true,
@@ -106,6 +109,7 @@ describe('DsfrMultiselect', () => {
106109
// When
107110
const { getByRole, getAllByRole } = render(DsfrMultiselect, {
108111
props: {
112+
label: 'Test multiselect avec recherche pour filtrer',
109113
modelValue: values,
110114
options,
111115
search: true,
@@ -139,6 +143,7 @@ describe('DsfrMultiselect', () => {
139143
// When
140144
const { getByRole } = render(DsfrMultiselect, {
141145
props: {
146+
label: 'Test multiselect avec sélection de tout',
142147
modelValue: values,
143148
options,
144149
selectAll: true,
@@ -191,6 +196,7 @@ describe('DsfrMultiselect', () => {
191196
// When
192197
const { getByRole, getByText } = render(DsfrMultiselect, {
193198
props: {
199+
label: 'Test multiselect avec options sous forme d’objets',
194200
modelValue: values,
195201
options,
196202
idKey: 'nom',

src/components/DsfrNavigation/DsfrNavigationMenuLink.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const iconProps = computed(() => (dsfrIcon.value || !props.icon)
2929
: { scale: defaultScale, ...((props.icon as Record<string, string>) || {}) },
3030
)
3131
32-
const useHeader = hasInjectionContext() ? inject(registerNavigationLinkKey)! : undefined
32+
const useHeader = hasInjectionContext() ? inject(registerNavigationLinkKey, undefined)! : undefined
3333
const closeModal = useHeader?.() ?? (() => {})
3434
</script>
3535

src/components/DsfrSelect/DsfrSelect.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ describe('DsfrSelect', () => {
118118
},
119119
})
120120
const selectEl = container.querySelector('select')
121-
console.log(selectEl?.innerHTML) // eslint-disable-line no-console
122121

123122
const optGroupEls = selectEl.querySelectorAll('optgroup')
124123
const optionEl1 = getByText('Text 1')
@@ -138,8 +137,5 @@ describe('DsfrSelect', () => {
138137
expect(optionEl3?.ariaDisabled).toBe('false')
139138
expect(optionEl4?.ariaDisabled).toBe('true')
140139
expect(optionEl4.disabled).toBe(true)
141-
142-
console.log(optGroupEls[0]?.ariaDisabled) // eslint-disable-line no-console
143-
console.log(optionEl1?.ariaDisabled) // eslint-disable-line no-console
144140
})
145141
})

src/components/DsfrSideMenu/DsfrSideMenu.stories.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -162,14 +162,14 @@ export const MenuLateralAvecAccordeonEtCheckbox: Story = {
162162
button-label="Afficher les filtres"
163163
>
164164
<DsfrAccordionsGroup>
165-
<DsfrAccordion
166-
v-for="(accordion, name) in args.accordions"
167-
:id="\`accordion_\${name}\`"
168-
:key="name"
169-
:id="name"
170-
:title="name"
171-
:expanded-id="expandedId"
172-
@expand="id => expandedId = id"
165+
<DsfrAccordion
166+
v-for="(accordion, name) in args.accordions"
167+
:id="\`accordion_\${name}\`"
168+
:key="name"
169+
:id="name"
170+
:title="name"
171+
:expanded-id="expandedId"
172+
@expand="id => expandedId = id"
173173
>
174174
<DsfrCheckboxSet
175175
:options="accordion.options"

0 commit comments

Comments
 (0)