Skip to content

Commit 419d47a

Browse files
committed
docs(DsfrDataTable): 📝 ajoute des précisions dans la doc
1 parent 8da2d8b commit 419d47a

File tree

9 files changed

+26
-10
lines changed

9 files changed

+26
-10
lines changed

‎src/components/DsfrAccordion/DsfrAccordion.spec.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ describe('DsfrAccordion', () => {
2626
props: {
2727
title,
2828
id: 'accordion-1',
29-
expandedId: undefined,
3029
},
3130
slots: {
3231
default: content,

‎src/components/DsfrDataTable/DsfrDataTable.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,14 @@
44

55
Le composant `DsfrDataTable` est un élément puissant et polyvalent pour afficher des données sous forme de tableaux dans vos applications Vue. Utilisant une combinaison de slots, de props, et d'événements personnalisés, ce composant offre une flexibilité remarquable. Plongeons dans les détails !
66

7+
::: warning Prudence
8+
9+
Ce composant est tout neuf et a besoin de vos retours. Son API ne devrait pas changer, elle devrait s’étoffer dans les prochaines semaines ou les prochains mois.
10+
11+
Si vous avez des propositions, lancer une [**discussion**](https://github.com/dnum-mi/vue-dsfr/discussions) avant d’ouvrir une issue.
12+
13+
:::
14+
715
🏅 La documentation sur le tableau sur le [DSFR](https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/tableau/)
816

917
<VIcon name="vi-file-type-storybook" /> La story sur le tableau de données sur le storybook de [VueDsfr](https://storybook.vue-ds.fr/?path=/docs/composants-dsfrdatatable--docs)

‎src/components/DsfrDataTable/DsfrDataTable.vue‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,14 @@ const pages = computed<Page[]>(() => props.pages ?? Array.from({ length: pageCou
6464
const lowestLimit = computed(() => currentPage.value * rowsPerPage.value)
6565
const highestLimit = computed(() => (currentPage.value + 1) * rowsPerPage.value)
6666
67-
function defaultSortFn (a, b) {
68-
const key = props.sorted
69-
if ((a[key] ?? a) < (b[key] ?? b)) {
67+
function defaultSortFn (a: string | DsfrDataTableRow, b: string | DsfrDataTableRow) {
68+
const key = props.sorted as string
69+
// @ts-expect-error TS7015
70+
if (((a as DsfrDataTableRow)[key] ?? a) < ((b as DsfrDataTableRow)[key] ?? b)) {
7071
return -1
7172
}
72-
if ((a[key] ?? a) > (b[key] ?? b)) {
73+
// @ts-expect-error TS7015
74+
if (((a as DsfrDataTableRow)[key] ?? a) > ((b as DsfrDataTableRow)[key] ?? b)) {
7375
return 1
7476
}
7577
return 0

‎src/components/DsfrMedia/DsfrVideo.spec.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ describe('DsfrVideo', () => {
88
it('should render a div with a small video with transcription', () => {
99
// Given
1010
const size = 'small'
11-
const format4x3 = false
1211
const src = 'https://www.youtube.com/embed/HyirpmPL43I'
1312
const legend = 'Vidéo de ouf'
1413

@@ -22,7 +21,6 @@ describe('DsfrVideo', () => {
2221
},
2322
props: {
2423
size,
25-
format4x3,
2624
src,
2725
legend,
2826
},

‎src/components/DsfrPagination/DsfrPagination.spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ describe('DsfrPagination', () => {
3232
await fireEvent.click(thirdLink)
3333

3434
// Then
35-
expect(emitted()['update:currentPage']).toBeTruthy()
36-
expect(emitted()['update:currentPage'][0][0]).toBe(2)
35+
expect(emitted()['update:current-page']).toBeTruthy()
36+
expect(emitted()['update:current-page'][0][0]).toBe(2)
3737
})
3838
})

‎src/components/DsfrRadioButton/DsfrRadioButton.spec.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ describe('DsfrRadioButton', () => {
1919
},
2020
props: {
2121
label,
22+
modelValue: undefined,
2223
value,
2324
name,
2425
},
@@ -50,6 +51,7 @@ describe('DsfrRadioButton', () => {
5051
props: {
5152
label,
5253
value,
54+
modelValue: undefined,
5355
name,
5456
img,
5557
},

‎src/components/DsfrTabs/DsfrTabs.spec.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ describe('DsfrTabs', () => {
8181
const title1 = 'Titre 1'
8282
const title2 = 'Titre 2'
8383
const title3 = 'Titre 3'
84+
const modelValue = ref(0)
8485

8586
const tabTitles = [
8687
{ title: title1 },
@@ -102,6 +103,7 @@ describe('DsfrTabs', () => {
102103
tabListName,
103104
tabTitles,
104105
tabContents,
106+
modelValue: modelValue.value,
105107
},
106108
})
107109

‎tsconfig.app.json‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
"extends": "@vue/tsconfig/tsconfig.dom.json",
33
"compilerOptions": {
44
"composite": true,
5+
"lib": [
6+
"ES2022",
7+
"DOM",
8+
"DOM.Iterable"
9+
],
510
"baseUrl": ".",
611
"rootDir": "./src",
712
"paths": {

‎tsconfig.vitest.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"extends": "./tsconfig.app.json",
33
"compilerOptions": {
44
"composite": true,
5-
"lib": [],
5+
"lib": ["ES2022"],
66
"types": ["node", "jsdom"]
77
},
88
"exclude": ["**/*.spec.ts", "**/*.stories.ts", "**/*.e2e.ts"]

0 commit comments

Comments
 (0)