Merge pull request #1129 from dnum-mi/fix/#1125-dsfr-input-group-with-disabled-value-false

Corrige l'activation de DsfrInputGroup quand la propriété disabled vaut false

Author: laruiss

src/components/DsfrInput/DsfrInputGroup.spec.ts

@@ -3,7 +3,7 @@ import { render } from '@testing-library/vue'
 import DsfrInputGroup from './DsfrInputGroup.vue'
 
 describe('DsfrInputGroup', () => {
-  it('should disabled DsfrInputGroup', () => {
+  it('should disable DsfrInputGroup with disabled="true"', () => {
     // Given
     const descriptionId = 'my-id'
     const inputGroupId = 'my-group-id'
@@ -26,6 +26,28 @@ describe('DsfrInputGroup', () => {
     expect(getByTestId(inputGroupId).querySelector('input')).toHaveProperty('disabled')
   })
 
+  it('should not disable DsfrInputGroup with disabled="false"', () => {
+    // Given
+    const descriptionId = 'my-id'
+    const inputGroupId = 'my-group-id'
+    const disabled = false
+
+    // When
+    const { getByTestId } = render(DsfrInputGroup, {
+      stubs: ['v-icon'],
+      props: {
+        descriptionId,
+        inputGroupId,
+        disabled,
+      },
+    })
+
+    // Then
+
+    expect(getByTestId(inputGroupId)).not.toHaveClass('fr-input-group--disabled')
+    expect(getByTestId(inputGroupId).querySelector('input')).toHaveProperty('disabled', false)
+  })
+
   it('should render DsfrInputGroup with error message', () => {
     // Given
     const errorMessage = 'my error message'

src/components/DsfrInput/DsfrInputGroup.vue

@@ -56,7 +56,7 @@ const descId = computed(() => {
     class="fr-input-group"
     :class="[
       {
-        'fr-input-group--disabled': 'disabled' in $attrs,
+        'fr-input-group--disabled': 'disabled' in $attrs && $attrs.disabled !== false && $attrs.disabled !== undefined,
         'fr-input-group--error': errorMessage,
         'fr-input-group--valid': (validMessage && !errorMessage),
       },

src/composables/useCollapsable.ts

@@ -50,7 +50,7 @@ export const useCollapsable = () => {
   /**
    * @see https://github.com/GouvernementFR/dsfr/blob/main/src/dsfr/core/script/collapse/collapse.js#L25
    * @param {boolean} expanded
-   * @param {boolean} focusFirstAnchor
+   * @param {boolean} autoFocus
    * @return void
    */
   const onTransitionEnd = (expanded: boolean, autoFocus = true): void => {