Skip to content

Commit b63cdde

Browse files
authored
Merge pull request #937 from dnum-mi/fix/bordure-en-tete
fix(DsfrHeader): 🐛 bordure en haut de navigation principale
2 parents bb40dc7 + 0fec3e6 commit b63cdde

File tree

4 files changed

+26
-23
lines changed

4 files changed

+26
-23
lines changed

demo-app/App.vue

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<script setup lang="ts">
22
import { computed, ref } from 'vue'
3-
import { useRoute } from 'vue-router'
43
4+
import { useRoute } from 'vue-router'
55
import DsfrBreadcrumb from '../src/components/DsfrBreadcrumb/DsfrBreadcrumb.vue'
6-
import DsfrFooter from '../src/components/DsfrFooter/DsfrFooter.vue'
76
7+
import DsfrFooter from '../src/components/DsfrFooter/DsfrFooter.vue'
88
import DsfrHeader, { type DsfrHeaderProps } from '../src/components/DsfrHeader/DsfrHeader.vue'
99
import DsfrModal from '../src/components/DsfrModal/DsfrModal.vue'
1010
import DsfrNavigation, { type DsfrNavigationProps } from '../src/components/DsfrNavigation/DsfrNavigation.vue'
@@ -245,21 +245,25 @@ const licenceTo = undefined
245245
const licenceName = undefined
246246
const licenceLinkProps = undefined
247247
const ecosystemLinks = [
248-
{
249-
label: 'legifrance.gouv.fr',
250-
href: 'https://legifrance.gouv.fr',
251-
},
252248
{
253249
label: 'info.gouv.fr',
254250
href: 'https://info.gouv.fr',
251+
title: 'Informations gouvernementales, nouvelle fenêtre',
255252
},
256253
{
257254
label: 'service-public.fr',
258255
href: 'https://service-public.fr',
256+
title: 'Informations et démarches administratives, nouvelle fenêtre',
257+
},
258+
{
259+
label: 'legifrance.gouv.fr',
260+
href: 'https://legifrance.gouv.fr',
261+
title: 'Service public de diffusion du droit, nouvelle fenêtre',
259262
},
260263
{
261264
label: 'data.gouv.fr',
262265
href: 'https://data.gouv.fr',
266+
title: 'Plateforme des données publiques, nouvelle fenêtre',
263267
},
264268
]
265269
@@ -289,7 +293,7 @@ const currentRoute = computed(() => route.name)
289293
<h1>Demo VueDsfr</h1>
290294

291295
<DsfrBreadcrumb
292-
:links="[{ text: 'Accueil', to: '/' }, { text: currentRoute }]"
296+
:links="[{ text: 'Accueil', to: '/' }, { text: (currentRoute as string) }]"
293297
/>
294298

295299
<router-view />
@@ -336,8 +340,4 @@ const currentRoute = computed(() => route.name)
336340
-webkit-font-smoothing: antialiased;
337341
-moz-osx-font-smoothing: grayscale;
338342
}
339-
340-
.my-1 {
341-
margin-block: 0.5rem;
342-
}
343343
</style>

src/components/DsfrHeader/DsfrHeader.types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export type DsfrHeaderMenuLinkProps = {
2020
* @deprecated Use the prop `to` instead
2121
*/
2222
path?: string
23+
class?: string | Record<string, string> | Array<string | Record<string, string>>
2324
}
2425

2526
export type DsfrHeaderProps = {

src/components/DsfrHeader/DsfrHeader.vue

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -273,19 +273,21 @@ provide(registerNavigationLinkKey, () => {
273273
</div>
274274
</div>
275275
</div>
276-
<div
277-
v-if="isWithSlotNav && !modalOpened"
278-
class="fr-hidden fr-unhidden-lg"
279-
>
280-
<!-- @slot Slot nommé mainnav pour le menu de navigation principal -->
281-
<slot
282-
name="mainnav"
283-
:hidemodal="hideModal"
284-
/>
285-
</div>
286276
<!-- @slot Slot par défaut pour le contenu du fieldset (sera dans `<div class="fr-header__body-row">`) -->
287277
<slot />
288278
</div>
289279
</div>
280+
<div class="fr-header__menu fr-modal">
281+
<div
282+
v-if="isWithSlotNav && !modalOpened"
283+
class="fr-container"
284+
>
285+
<!-- @slot Slot nommé mainnav pour le menu de navigation principal -->
286+
<slot
287+
name="mainnav"
288+
:hidemodal="hideModal"
289+
/>
290+
</div>
291+
</div>
290292
</header>
291293
</template>

src/components/DsfrHeader/docs-demo/DsfrHeaderDemo.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ import { createRouter, createWebHistory } from 'vue-router'
44
import type { DsfrLanguageSelectorElement } from '@/components/DsfrLanguageSelector/DsfrLanguageSelector.types'
55
66
import VIcon from '../../VIcon/VIcon.vue'
7-
import DsfrHeader from '../DsfrHeader.vue'
7+
import DsfrHeader, { type DsfrHeaderProps } from '../DsfrHeader.vue'
88
99
const logoText = ['Ministère', 'de l’intérieur']
1010
const serviceTitle = 'Nom du Site/Service'
1111
const serviceDescription = 'baseline - précisions sur l‘organisation'
1212
const placeholder = ''
1313
const homeTo = '/'
14-
const quickLinks = [
14+
const quickLinks: DsfrHeaderProps['quickLinks'] = [
1515
{ label: 'Créer un espace', to: '/space/create', icon: 'ri-add-circle-line', iconRight: true },
1616
{ label: 'Se connecter', to: '/login', class: 'fr-icon-user-fill' },
1717
{ label: 'S’enregistrer', to: '/signup', icon: 'ri-account-circle-line', iconRight: true, iconAttrs: { animation: 'spin', speed: 'slow' } },

0 commit comments

Comments
 (0)