Skip to content

Commit e671bd0

Browse files
authored
Merge pull request #963 from dnum-mi/fix/class-in-dsfr-header-menu-link
fix: πŸ› class should be passed to DsfrHeaderMenuLink
2 parents bb4d8d4 + 86a7f9d commit e671bd0

File tree

4 files changed

+35
-16
lines changed

4 files changed

+35
-16
lines changed

β€Ž.github/workflows/run-tests.ymlβ€Ž

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ jobs:
1919
VITE_APP_GIT_SHA: ${{github.sha}}
2020

2121
steps:
22-
- uses: actions/checkout@v2
22+
- uses: actions/checkout@v4
2323
- name: Setup Node.js
24-
uses: actions/setup-node@v2
24+
uses: actions/setup-node@v4
2525
with:
26-
node-version: 20
26+
node-version: 22
2727
- name: Install pnpm
2828
run: npm i -g pnpm
2929
- name: Install dependencies

β€Žpackage.jsonβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@
8888
"@commitlint/cli": "^19.4.1",
8989
"@commitlint/config-conventional": "^19.4.1",
9090
"@iconify/vue": "^4.1.2",
91+
"@playwright/test": "1.48.1",
9192
"@storybook/addon-a11y": "^8.3.0",
9293
"@storybook/addon-docs": "^8.3.0",
9394
"@storybook/addon-essentials": "^8.3.0",
@@ -130,7 +131,6 @@
130131
"lint-staged": "^15.2.10",
131132
"npm-run-all": "^4.1.5",
132133
"p-debounce": "^4.0.0",
133-
"playwright": "^1.47.0",
134134
"publint": "^0.2.10",
135135
"regenerator-runtime": "^0.14.1",
136136
"rimraf": "^6.0.1",

β€Žpnpm-lock.yamlβ€Ž

Lines changed: 30 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žsrc/components/DsfrHeader/DsfrHeader.types.tsβ€Ž

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export type DsfrHeaderMenuLinkProps = {
2020
* @deprecated Use the prop `to` instead
2121
*/
2222
path?: string
23-
class?: string | Record<string, string> | Array<string | Record<string, string>>
2423
}
2524

2625
export type DsfrHeaderProps = {
@@ -34,7 +33,7 @@ export type DsfrHeaderProps = {
3433
operatorImgSrc?: string
3534
operatorImgStyle?: StyleValue
3635
placeholder?: string
37-
quickLinks?: DsfrHeaderMenuLinkProps[]
36+
quickLinks?: (DsfrHeaderMenuLinkProps & HTMLAttributes)[]
3837
languageSelector?: DsfrLanguageSelectorProps
3938
searchLabel?: string
4039
quickLinksAriaLabel?: string

0 commit comments

Comments
Β (0)