Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Conversation

chungers
Copy link
Contributor

@chungers chungers commented Feb 3, 2017

No description provided.

David Chung added 4 commits February 1, 2017 18:52
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "release-0.3.0" git@github.com:docker/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353248144
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov-io
Copy link

codecov-io commented Feb 3, 2017

Codecov Report

Merging #383 into master will increase coverage by -0.18%.

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   62.58%   62.41%   -0.18%     
==========================================
  Files          55       55              
  Lines        2932     2932              
==========================================
- Hits         1835     1830       -5     
- Misses        881      883       +2     
- Partials      216      219       +3
Impacted Files Coverage Δ
pkg/template/funcs.go 75.29% <100%> (ø)
pkg/manager/group_plugin_impl.go 14.89% <ø> (-4.26%)
pkg/manager/manager.go 63.63% <ø> (-1.82%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18e3e1...fc5244a. Read the comment docs.

@chungers chungers merged commit 4b179b1 into master Feb 3, 2017
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
added retries to swarm join, in case first try fails
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants