-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EOL 2.7 #228
Remove EOL 2.7 #228
Conversation
@@ -59,7 +59,7 @@ ENV HAPROXY_SHA256 {{ .sha256 }} | |||
# Since 5.4 is supported on haproxy, better use it now, but only for | |||
# newer versions since there could be some minor incompatibilities | |||
# for existing scripts: https://www.lua.org/manual/5.4/manual.html#8 | |||
if ([ "2.0", "2.2", "2.4", "2.6", "2.7", "2.8" ] | index(env.version)) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimWolla 2.0 is also out of LTS and also EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.0 is not EOL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i found 2 sources that said it is and one that was ambiguous. It can be done in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what sources you used, but the official project homepage does not list HAProxy 2.0 as EOL: https://www.haproxy.org/. And neither does yesterday's release announcement of HAProxy 2.0.35 (whereas the one for 2.7.12 did): https://www.mail-archive.com/haproxy@formilux.org/
We'll wait until after docker-library/official-images#16555, so that we push the final release. |
(Rebased thanks to #226 😅) |
and now docker-library/official-images#16555 is not just merged but fully built and published 🚀 |
I don't think we really need to wait for CI here 😄 |
Changes: - docker-library/haproxy@1cae2e3: Merge pull request docker-library/haproxy#228 from TimWolla/2.7-eol - docker-library/haproxy@2dbe02f: Remove EOL 2.7
No description provided.