-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Alpine 3.20 #231
Conversation
33692d5
to
3968cc8
Compare
@@ -39,10 +37,10 @@ for version in "${versions[@]}"; do | |||
debian: env.debian, | |||
alpine: env.alpine, | |||
} | |||
| if env.version == "2.2" then del(.alpine) else . end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason not to put the comment directly here in the jq
instead? 😅
(maybe even match on .version | startswith("2.2.")
so we can avoid export version
at all?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, we use export version
further down -- in that case I'd actually move it even further up to the first line of the for
(right after it's definitely got the value we expect).
remove EOL 2.0
Changes: - docker-library/haproxy@67485bd: Merge pull request docker-library/haproxy#231 from infosiftr/alpine3.20 - docker-library/haproxy@5804096: Update to Alpine 3.20
Note: Technically HAProxy 2.0 is not EOL yet. See: #228 (comment) |
Doh, yep, we should bring that back (and only drop the Alpine variants of it). |
(Thank you!) |
Changes: - docker-library/haproxy@fa5d16b: Merge pull request docker-library/haproxy#232 from infosiftr/restore-2.0 - docker-library/haproxy@7eb71e6: Restore 2.0 (not yet EOL) - docker-library/haproxy@67485bd: Merge pull request docker-library/haproxy#231 from infosiftr/alpine3.20 - docker-library/haproxy@5804096: Update to Alpine 3.20
Remove EOL
2.0
images. Remove Alpine from the2.2
image since it cannot be built on a supported release of Alpine now that 3.16 is end of life.Related docker-library/official-images#16801