Set the PHP_BUILD_PROVIDER variable #1441
Conversation
Dockerfile-linux.template
Outdated
| ARG PHP_BUILD_PROVIDER="Docker Official Images" | ||
|
|
There was a problem hiding this comment.
Would it be possible for the actual builders to set this argument? This would allow the actually official builds to carry the tag, whereas and manual builds of the Dockerfiles do not.
|
Example screenshot (with messed up quoting, thus cutting off at the space, but I didn't want to rebuild, because it takes ages):
|
|
Oof, looking at that upstream block is giving me some hives -- we should probably set Maybe we set the provider to "https://github.com/docker-library/php" so it doesn't really matter as much where the builds happened? I guess that won't help for modified builds, but I don't think there's much we can actually do there (and it's then an accurate pointer to where the source originated, even if it was then modified). Also, I'd prefer to set these in the |
TimWolla
force-pushed
the
build-provider
branch
from
e3ad86b to
33a7c62
Compare
|
Updated. |
tianon
force-pushed
the
build-provider
branch
from
33a7c62 to
f14ade9
Compare
tianon
force-pushed
the
build-provider
branch
from
f14ade9 to
5f736d0
Compare
Changes: - docker-library/php@0aff58cf: Merge pull request docker-library/php#1475 from infosiftr/php_uname - docker-library/php@50c8b1ce: Set PHP_UNAME to a fixed value too - docker-library/php@f42c0a54: Merge pull request docker-library/php#1441 from TimWolla/build-provider - docker-library/php@4299a66f: Update GHA YAML with bashbrew example improvements (esp. concurrency:) - docker-library/php@5f736d03: Set the PHP_BUILD_PROVIDER variable
see https://github.com/php/php-src/blob/789867e844dc0465fe01a703a1bef2a7dba0c62b/configure.ac#L1500-L1502 see https://phpc.social/@remi/110543114152140626