initial take on adding support for tls auth with client certificates

[denibertovic]

The support has just been merged to docker master a few days ago: http://docs.docker.io/en/master/examples/https/

[denibertovic]

ping @shin-

let me know what you think.

[shin-]

LGTM! =)

[shin-]

Could the tls boolean be implied by the presence of cert and key?

[mpetazzoni]

Similarly, can't it be implied by the fact that the base_url starts with https:// ?

[denibertovic]

I was trying to mimic what we already have with the CLI: http://docs.docker.io/en/master/examples/https/#client-modes

If you look at the docs you will see that I've only covered the 3rd option, cause that's the one that i specifically need at this time. At some point we should probably cover the others but this one seems like the one people will need the most (ie. the client authenticating to the server with a client certificate).

[shin-]

Makes sense. I'd say we add the other parameters then and raise NotImplementedError when provided with an unsupported combination. What do you guys think?

[mpetazzoni]

+1

[momer]

@denibertovic Are you going to implement @shin- feedback? I missed this issue in my search for SSL, and rewrote it just a lil bit ago. Glad there's already a PR, but can we get the feedback implemented and merge this?

[denibertovic]

@momer @shin- sorry I was busy for quite a while. I can take another crack at this over the weekend but if you feel that you can get it done before then (or do you already have everything?) feel free to work with shin to get it merged.

[momer]

I'll send it through in a second here 👍 for your work on this so far.

[fermayo]

+1

[bernardopericacho]

+1

[momer]

Haven't heard back yet regarding this @shin- #226

[shin-]

Closing in favor of #226