Complete TLS/SSL Support, near-mirror of Docker CLI #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for SSL in docker-py. Including the ability to specify the expected SSL Version for issues with OpenSSL sslv3/tls1 recognition issues. Added an exception class for repetitive reminders to look at the CLI doc on docker.io.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an expansion of @denibertovic 's work on #187
I'd re-done some of his work today, and expanded on it quite a bit by the time I realized it existed here. I've forked his commit to give him credit, and expanded on his work.
Note: This is my first time writing Python longer than 5-10 lines. Let me know if there are any code smells! I know the Exception class can be a sticking point, but I felt it was important to remind the user where the TLS API comes from, and to DRY that up a bit.
Also, I left a bunch of comments to help readers understand why some of the additions are necessary. Tests pass, and I connect fine using the options; but, alas, I haven't written any new tests for this PR.