Redux added arguments to create a swarm with a custom address pool and subnet size. #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 22, 2019 10:38
…net size. Signed-off-by: Barry Shapira <barry@whiterabbit.ai>
Also corrected a documentation error: the default API version from constants is currently 1.35, not 1.30 as was sometimes listed. Signed-off-by: Barry Shapira <barry@whiterabbit.ai> Removed accidental whitespace. Signed-off-by: Barry Shapira <barry@whiterabbit.ai>
The integration tests require restarting the swarm once for each test. I had done so manually with self.init_swarm(force_new_cluster=True) but that wasn't resetting the swarm state correctly. The usual test teardown procedure cleans up correctly. Signed-off-by: Barry Shapira <barry@whiterabbit.ai>
|
I’ll have a look at why the test |
|
Please sign your commits following these rules: $ git clone -b "swarm-default-addr-pool-redux" git@github.com:hannseman/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842359386800
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
hannseman
force-pushed
the
swarm-default-addr-pool-redux
branch
from
24c925e to
cb17091
Compare
hannseman
force-pushed
the
swarm-default-addr-pool-redux
branch
7 times, most recently
from
ff29e00 to
d6c6853
Compare
Following docker#2201 (review) Signed-off-by: Hannes Ljungberg <hannes@5monkeys.se> Co-authored-by: Hannes Ljungberg <hannes@5monkeys.se> Co-authored-by: bluikko <14869000+bluikko@users.noreply.github.com>
hannseman
force-pushed
the
swarm-default-addr-pool-redux
branch
from
d6c6853 to
68a271c
Compare
|
Had some trouble adding @bluikko as Co-Author of the commit. Hence all the force-pushes. |
ijc
approved these changes
Mar 25, 2019
|
Thanks @bluikko and @hannseman! |
|
@ijc @chris-crone thanks for the review and merge! |
|
Thank you @ijc @hannseman for making it happen, my first attempt at githib was puny but I hope it at least brought some attention to this request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the work started in #2201 and #2261.
Fixes #2201
Fixes #2261
Fixes #2200
cc @bluikko