Move volume_driver to RUN_HOST_CONFIG_KWARGS #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes docker#2271 Signed-off-by: Hannes Ljungberg <hannes@5monkeys.se>
shin-
approved these changes
Mar 23, 2019
|
Yes I saw that failure of |
|
I kicked Jenkins. |
|
And it's green on repeat, I will merge based on @shin-'s earlier LGTM. Thanks @hannseman I raised #2291 for the flakey test which this hit the first time.. |
This was referenced Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
volume_driveris passed tocontainers.createit will crash as it have been moved toHostConfigin theAPIClient.This PR moves
volume_driverfromRUN_CREATE_KWARGStoRUN_HOST_CONFIG_KWARGS.Added a test to verify the fix.
Fixes #2271