Skip to content

Conversation

aanand
Copy link
Contributor

@aanand aanand commented Sep 1, 2015

Following the logic of the Docker client.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we make platform optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't realise it was public API, so I guess we have to. Will fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Following the logic of the Docker client.

Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@aanand aanand force-pushed the default-to-tcp-url-on-windows branch from dc31124 to 1362938 Compare September 1, 2015 23:28
@mpetazzoni
Copy link
Contributor

👍

shin- added a commit that referenced this pull request Sep 1, 2015
@shin- shin- merged commit 7dce129 into docker:master Sep 1, 2015
@aanand aanand deleted the default-to-tcp-url-on-windows branch September 3, 2015 00:50
@shin- shin- added this to the 1.4.0 milestone Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants