Fix race condition in integration regression tests #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbellamy
force-pushed
the
test-race-condition
branch
from
53c86c0 to
7588dc3
Compare
`docker port` and inspect do not return ports for containers which are not running. Because the container command is `true`, sometimes that exits before the inspect is called. Signed-off-by: Paul Bellamy <paul.a.bellamy@gmail.com>
paulbellamy
force-pushed
the
test-race-condition
branch
from
7588dc3 to
19291ee
Compare
|
LGTM |
1 similar comment
|
LGTM |
mnowster
added a commit
that referenced
this pull request
Oct 1, 2015
Fix race condition in integration regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker portand inspect do not return ports for containers which arenot running. Because the container command is
true, sometimes thatexits before the inspect is called.
Fixes #795