Skip to content

Conversation

lots0logs
Copy link
Contributor

No description provided.

Signed-off-by: Dustin Falgout <dustin@falgout.us>
@shin-
Copy link
Contributor

shin- commented Oct 21, 2015

Thanks!

The tests are failing because you have trailing whitespace and an indentation error in your patch. You can run make flake8 in the project's root to detect those locally.

Apart from the code style nitpicking:

  • It seems the option was added in API version 1.20 - can we add a client-side check for that? Just like we do for group_add here
  • The parameter should be added to the HostConfig documentation (docs/host_config.md).
  • It might also be valuable to add an integration test that verifies the value we pass is reflected in the inspect_container dict.

@shin- shin- added this to the 1.6.0 milestone Oct 21, 2015
lots0logs added a commit to lots0logs/docker-py that referenced this pull request Oct 31, 2015
lots0logs added a commit to lots0logs/docker-py that referenced this pull request Oct 31, 2015
Signed-off-by: Dustin Falgout <dustin@falgout.us>
@lots0logs lots0logs closed this Oct 31, 2015
lots0logs added a commit to lots0logs/docker-py that referenced this pull request Nov 5, 2015
Signed-off-by: Dustin Falgout <dustin@falgout.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants