Add support for MemorySwappiness to client.create_host_config() #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lots0logs
changed the title
client.create_host_config()
lots0logs
force-pushed
the
814-host-config-mem-swap
branch
from
09f1ff1 to
7df642c
Compare
docker/utils/utils.py
Outdated
There was a problem hiding this comment.
Why parse_bytes here? Isn't it supposed to be a simple integer value between 0 and 100?
lots0logs
force-pushed
the
814-host-config-mem-swap
branch
from
fc91e84 to
59ad6e0
Compare
Signed-off-by: Dustin Falgout <dustin@falgout.us>
lots0logs
force-pushed
the
814-host-config-mem-swap
branch
from
77887c0 to
c07dd53
Compare
Signed-off-by: Dustin Falgout <dustin@falgout.us>
Signed-off-by: Dustin Falgout <dustin@falgout.us>
lots0logs
force-pushed
the
814-host-config-mem-swap
branch
from
3a70fe1 to
64fc383
Compare
|
Thanks! Sorry it took me a while to take another look. LGTM now. 👍 |
|
@shin- Who can I tag to get the second LGTM? |
|
LGTM |
dnephin
added a commit
that referenced
this pull request
Nov 16, 2015
Add support for MemorySwappiness to client.create_host_config()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates feedback from and closes #814
Signed-off-by: Dustin Falgout dustin@falgout.us