Fix enable_tls issue #988
Fix enable_tls issue #988
Conversation
Signed-off-by: Joffrey F <joffrey@docker.com>
|
I have a try and #984 is fixed.thank you. |
| self.assertFalse(kwargs['tls'].verify) | ||
| except TypeError as e: | ||
| self.fail(e) | ||
| self.assertEqual('tcp://192.168.59.103:2376', kwargs['base_url']) |
There was a problem hiding this comment.
From this test change it's not clear to me what the expected behaviour is supposed to be.
It seems like we're reverting part of the recent change, is that right?
There was a problem hiding this comment.
Yes. I tested that case locally with the docker CLI, and setting DOCKER_TLS_VERIFY to empty string and DOCKER_HOST to a TCP address let me connect to an unsecured daemon, so I believe this change is correct.
|
LGTM |
|
Please sign your commits following these rules: $ git clone -b "tls-fixes" git@github.com:docker/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmmending updates the existing PR. You DO NOT need to open a new one. |
1 similar comment
|
Please sign your commits following these rules: $ git clone -b "tls-fixes" git@github.com:docker/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmmending updates the existing PR. You DO NOT need to open a new one. |
Fixes #984 (?)