-
Notifications
You must be signed in to change notification settings - Fork 2k
Investigate 1954 certificate always regenerated #2006
Investigate 1954 certificate always regenerated #2006
Conversation
@@ -419,6 +419,7 @@ func runActionForeachMachine(actionName string, machines []*host.Host) []error { | |||
go machineCommand(actionName, machine, serialChan) | |||
if err := <-serialChan; err != nil { | |||
log.Errorln(err) | |||
errs = append(errs, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice catch
b08e262
to
3bcc832
Compare
3bcc832
to
c9217e8
Compare
dialer := &net.Dialer{ | ||
Timeout: time.Second * 2, | ||
} | ||
|
||
_, err = tls.DialWithDialer(dialer, "tcp", addr, tlsConfig) | ||
if err != nil { | ||
log.Debugf("Certs are not valid: %s", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carolynvs: Does your output refer to this line: #1954 (comment) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes line 216 from this diff above causes that message to be printed on the client and on the server I see that error about cert dates in docker.log on the host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgageot @nathanleclaire We should probably keep this debugging line in the release? It helps debugging when people are not capable of building some debugging PR by simply posting those lines in their issue...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, more debugging output usually helps.
Signed-off-by: David Gageot <david@gageot.net>
30a9399
to
e2b6a83
Compare
@nathanleclaire @dmp42 Can you please take a look? |
LGTM |
…ated Investigate 1954 certificate always regenerated
we are hunting this down, it seems a valid date issue, boot2docker having a bad |
too late but LGTM |
So, this does not solve anything but adds more logs during the certificates validation.