Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

Investigate 1954 certificate always regenerated #2006

Merged
merged 1 commit into from Oct 22, 2015

Conversation

dgageot
Copy link
Member

@dgageot dgageot commented Oct 19, 2015

So, this does not solve anything but adds more logs during the certificates validation.

@@ -419,6 +419,7 @@ func runActionForeachMachine(actionName string, machines []*host.Host) []error {
go machineCommand(actionName, machine, serialChan)
if err := <-serialChan; err != nil {
log.Errorln(err)
errs = append(errs, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice catch

@dgageot dgageot force-pushed the 1954-certificate-always-regenerated branch 2 times, most recently from b08e262 to 3bcc832 Compare October 20, 2015 08:30
@dgageot dgageot self-assigned this Oct 21, 2015
@dgageot dgageot force-pushed the 1954-certificate-always-regenerated branch from 3bcc832 to c9217e8 Compare October 21, 2015 10:34
dialer := &net.Dialer{
Timeout: time.Second * 2,
}

_, err = tls.DialWithDialer(dialer, "tcp", addr, tlsConfig)
if err != nil {
log.Debugf("Certs are not valid: %s", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolynvs: Does your output refer to this line: #1954 (comment) ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes line 216 from this diff above causes that message to be printed on the client and on the server I see that error about cert dates in docker.log on the host.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgageot @nathanleclaire We should probably keep this debugging line in the release? It helps debugging when people are not capable of building some debugging PR by simply posting those lines in their issue...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, more debugging output usually helps.

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the 1954-certificate-always-regenerated branch from 30a9399 to e2b6a83 Compare October 22, 2015 09:12
@dgageot dgageot changed the title [WIP] Investigate 1954 certificate always regenerated Investigate 1954 certificate always regenerated Oct 22, 2015
@dgageot
Copy link
Member Author

dgageot commented Oct 22, 2015

@nathanleclaire @dmp42 Can you please take a look?

@dmp42
Copy link
Contributor

dmp42 commented Oct 22, 2015

LGTM
Thanks @dgageot !

dmp42 added a commit that referenced this pull request Oct 22, 2015
…ated

Investigate 1954 certificate always regenerated
@dmp42 dmp42 merged commit 1a6a9de into docker:master Oct 22, 2015
@blaggacao
Copy link
Contributor

we are hunting this down, it seems a valid date issue, boot2docker having a bad date #1954

@nathanleclaire
Copy link
Contributor

too late but LGTM

@dgageot dgageot deleted the 1954-certificate-always-regenerated branch January 25, 2016 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants