-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARM] Use arm32v6/node alpine base image #102
Conversation
@alexellis seems reasonable, what do you think? |
Image size reduction: 416MB -> 155MB
Sounds like a good idea to me |
hey @ManoMarks , as a large contributor to this project I would be happy to get collaborator privileges and become more involved |
Sorry @DovAmir we only have Docker employees or contractors as team members. Also we're not really actively developing this sample, just patching as problems emerge. Thanks for the offer though. |
Have you tried just using the main |
Moving to the official Node image for ARM is a good idea. Only thing might be if we should use the Node LTS version, which is 8. |
Good idea @estesp. For such a cleanup I suggest to remove the Dockerfile.aarch64 and Dockerfile.arm and use the multi-arch Next step could be to cleanup up the README.md and just use image name |
This change makes sense - the size difference is because I used Raspbian as a base image for my original version and now we have access to Alpine for ARM which is lighter weight. The image being pointed at I believe is the official arm image already, but we can point at the "shortcut" or "main" image which is called "node:9-alpine" (like Stefan/Phil pointed out) I will take some time today to test it out and let you know how it looks. As for ARM64 that should work too. Edit: I can confirm that |
Thanks Alex. The 8.2.1 was perhaps before they started with node multi-arch images. |
Made obsolete by #105 |
By changing the base image to arm32v6/node I reduced the image size from 416MB to 155MB.
Might not sound like much, but keep in mind that Raspberry Pis and other ARM based microcomputers are often equipped with litte memory.
It's running on my Pi for a week now without issues.