[bug fix] errorMessages() messages doesn't contain parameters #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously all param replacements would only be applied if showMessages() had been fired and they where not stored in the errorMessages property
stuyam
reviewed
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When just using the
validator.getErrorMessages()method, it only uses the message with the field replaced. So you get a message likeThe name must be at least :min:type.This was happening as they where being stored before the params where being replaced, as that was only firing if the
showMessages()had been fired.This patch fixes that, so you can just pull the fully formatted error messages out, without firing
showMessages().