fix: DoclingDocument model validator should deal with any raw input #419
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ DCO Check Passed Thanks @ceberam, all your commits are properly signed off. 🎉 |
|
Related Documentation Checked 3 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
cau-git
previously approved these changes
Nov 13, 2025
vagenas
reviewed
Nov 13, 2025
test/test_docling_doc.py
Outdated
|
|
||
| # test that transform_to_content_layer model validator can handle any data type | ||
| class ContentOutput(BaseModel): | ||
| content: str | DoclingDocument |
Collaborator
There was a problem hiding this comment.
Union needed here for 3.9
Collaborator
Author
There was a problem hiding this comment.
I have also added a minor update in README
Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
ceberam
force-pushed
the
fix/model-validator-2616
branch
from
01a85de to
99dec97
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
ceberam
force-pushed
the
fix/model-validator-2616
branch
from
99dec97 to
ab24dd7
Compare
vagenas
approved these changes
Nov 13, 2025
cau-git
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
transform_to_content_layermodel validator ofDoclingDocumentis of type before, since it may need to transform the raw input before theDoclingDocumentis instantiated.However, it assumes that the raw input data is a
dictand this may create issues like described in docling-project/docling#2616.Since before validators have to deal with the raw input, which in theory could be any arbitrary object, a type check has been added.
Resolves docling-project/docling#2616