make it possible to load multiple languages of a previously persisted document

[lsmith77]

$user1 = new \Doctrine\Tests\Models\CMS\CmsUserTranslatable();
$user1->name = 'david';
$user1->username = 'dbu';
$user1->status = 'activ';
$this->dm->persist($user1);
$this->dm->bindTranslation($user1, 'en');
$user1->status = 'actif';
$this->dm->bindTranslation($user1, 'fr');

$this->dm->flush();
$this->assertEquals(0, $this->listener->count);
$this->dm->clear();

$user1 = $this->dm->findTranslation(null, $user1->id, 'en');
$this->dm->findTranslation(null, $user1->id, 'fr');

$this->dm->flush();

$this->assertEquals(0, $this->listener->count);

$user1 = $this->dm->findTranslation(null, $user1->id, 'en');
$user1->status = 'active';
$this->dm->loadTranslation($user1, 'fr'); // currently not possible

$this->dm->flush();

$this->assertEquals(1, $this->listener->count);
$this->dm->clear();

$user1 = $this->dm->findTranslation(null, $user1->id, 'en');
$this->assertEquals('active', $user1->status);

[dbu]

"not possible" meaning there is an error, or we reset the translation?

[dbu]

the thing is I think it would be inconsistent with |$dm->find()| if we
would keep changes around as there all changes would be overwritten ..
so I think for this sort of use case, we need to expose
|doLoadTranslation()| to be able to load additional translations for an
already fetched document. I imagine this could be useful for a form
where one can enter/edit translations into multiple languages at the
same time.

i agree that we need to be consistent between the two. but my impression from reading find() is that it gives you the document that is already in memory, so not reseting anything (and not even changing the locale if its not the default one, which could be surprising but i think we discussed that and saids its even more surprising if you have a reference to the document somewhere and the locale changes just because you did find() somehwere)

with findTranslation, we reset to the previously bound translation if there is any (doLoadPendingTranslation). but we seem to not detect if we try to load the language that is already loaded (there is a comment // if no locale is specified, we reset the current translation which seems the wrong thing to do. rather, we should abort if this is not a refresh operation.)

when switching the locale, we discard the current translated fields. i think this makes sense, as otherwise you could not avoid it.

[lsmith77]

"not possible" as in the API is missing

[dbu]

ah, i see. i think find is doing what you mean by load. or should be, bare some bugs. it should just keep the current state if that is whats already loaded.

for the other operation, we have refresh which does reload the translation as well. i just notice that we problably should pass along the locale in doRefresh where we call getOrCreateDocument so the document is refreshed in its current locale.

[dbu]

@lsmith77 is there anything left to do in this issue?