Id generator (WIP) #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
people lost their degree for copy paste lately ;-)
There was a problem hiding this comment.
hehe .. you are still listed as the author :)
There was a problem hiding this comment.
or in other words .. i started implementing it .. and then got lazy :)
…fied (replaced by a repository callback). still needs support in mapping drivers, also can we provide a default implementation in the repository class (then we can remove the interface and default to the repository generator)
|
FYI this change is discussed here http://groups.google.com/group/symfony-cmf-devs/browse_thread/thread/73c2e88037876362 |
There was a problem hiding this comment.
Inside the Doctrine code you can use $cm->reflFields->getValue($document, $cm->path); for performance reasons.
|
I think I will add another generator ParentRelativePathGenerator. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a quick adaption of the CouchDB ODM code for id generation. for now i am leaving the question of renaming "path" to "id" open (aka $this->identifier vs. $this->path in ClassMetadata). the SlugifiedGenerator is just an illustration of how things could potentially look like.
one obvious issue with the code that i took from CouchDB is that its currently not possible to register custom ID generators. aka it would be nice to be able to register a generator that does some custom logic using some properties (like category, creation date) to automatically generate a path that distributes content over subnodes to prevent hitting performance limits of Jackrabbit.