split annotations into separate files #412
Conversation
Allow the phpcr annotations to be used without modifying the app/autoload.php file. The DoctrineAnnotations does a require_once to ensure existing projects can continue to function
| * @Target("METHOD") | ||
| */ | ||
| final class PostLoad {} | ||
| require_once('./Document.php'); |
There was a problem hiding this comment.
think its necessary to use __DIR__ here
There was a problem hiding this comment.
so like?
require_once( __DIR__ .'/Document.php');
There was a problem hiding this comment.
yes. though I would prefer require_once __DIR__ .'/Document.php';
|
Looks good, I know the things I point out were there in the original code, but seems like a good time to fix them. |
| */ | ||
| public $type = 'name'; | ||
| } | ||
|
|
There was a problem hiding this comment.
Empty line at end of file
| @@ -21,355 +21,41 @@ | |||
|
|
|||
| use Doctrine\Common\Annotations\Annotation; | |||
There was a problem hiding this comment.
this use statement can be removed. i propose that we add a comment in this file that its not needed to include this anymore as autoloading works. something like
/**
* Deprecated
*
* Including this file is no longer needed, as each annotation was moved into its own file
* supporting PSR-0 compatible autoloading.
* The file is kept for backwards compatibility and will be removed in a future version of phpcr-odm.
*/
There was a problem hiding this comment.
added that command directly in master. thanks again @gnat42
|
awesome! travis passing means there are most likely no mistakes in this. did you test this in a project too, or only with the tests? |
split annotations into separate files
Registering annotations should no longer be necessary. (doctrine/phpcr-odm#412)
Allow the phpcr annotations to be used without modifying the app/autoload.php
file. The DoctrineAnnotations does a require_once to ensure existing projects
can continue to function