no longer refresh translations on a load translation call #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dbu |
|
seems correct to me. to test, you would load a document, change a field, do a loadTranslation and check that the field was not reset. and i would add a note to the changelog as its a bugfix with a potential to break something if it relied on this. |
lsmith77
force-pushed
the
make_findTranslation_consistent
branch
from
994dbaa to
e917f7c
Compare
There was a problem hiding this comment.
we were clearing the loaded translations on flush, which I guess was a memory optimization but caused the translations to be loaded again either way.
|
@dbu can you review and merge? |
|
what about a note in the changelog? |
lsmith77
force-pushed
the
make_findTranslation_consistent
branch
from
e917f7c to
434849c
Compare
|
added |
…nger unload translations after a flush()
lsmith77
force-pushed
the
make_findTranslation_consistent
branch
from
434849c to
a3ec655
Compare
dbu
added a commit
that referenced
this pull request
Oct 6, 2014
no longer refresh translations on a load translation call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to fix #557
but how to test this?