Skip to content

Use null object pattern to decrease complexity #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2020
Merged

Use null object pattern to decrease complexity #25

merged 1 commit into from
Apr 4, 2020

Conversation

greg0ire
Copy link
Member

Closes #22

goetas
goetas reviewed Mar 29, 2020
View reviewed changes
@greg0ire greg0ire mentioned this pull request Apr 1, 2020
Merged
SenseException
SenseException previously requested changes Apr 1, 2020
View reviewed changes
src/HtmlHighlighter.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe sprintf() and PHP_EOL would make this more readable.

src/CliHighlighter.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe sprintf() and PHP_EOL would make this more readable.

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
line breaks, pass in a `NullHighlighter` instance as the second parameter.
line breaks, pass in a `NullHighlighter` instance.

@greg0ire greg0ire requested a review from SenseException April 1, 2020 20:14
goetas
goetas approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@goetas goetas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not that strong opinion on the highlighter, I think either way is better than what it was before, so 👍👍

@greg0ire
Copy link
Member Author

greg0ire commented Apr 4, 2020

@SenseException please review again

@greg0ire greg0ire dismissed SenseException’s stale review April 4, 2020 16:02

I need to move on, but feel free to review what is already merged

@greg0ire greg0ire merged commit 735a373 into doctrine:master Apr 4, 2020
@greg0ire greg0ire deleted the null-highlighter branch April 4, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetas goetas goetas approved these changes

@SenseException SenseException Awaiting requested review from SenseException

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement NullHighlighter
3 participants
@greg0ire @goetas @SenseException