Extract tokenization #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The complicated part wasn't extracting the tokenizer, it was making |
greg0ire
commented
Mar 29, 2020
goetas
previously approved these changes
Apr 1, 2020
src/Tokenizer.php
Outdated
There was a problem hiding this comment.
It's needed for tests/performance.php, and unit tests, but apart from that, not really, now. Doesn't really hurt though, does it?
src/SqlFormatter.php
Outdated
There was a problem hiding this comment.
Reminder: i still think that this param should go away and be passes in the specific method when possible
There was a problem hiding this comment.
I'm not forgetting, I have #25 as a reminder ;)
|
to me looks good, I've just left some minor notes |
greg0ire
force-pushed
the
extract-tokenization
branch
from
9c289f0 to
705a800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.