Sort documentation in code order. #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcw
force-pushed
the
file-order
branch
2 times, most recently
from
7991c58 to
1a5f4e0
Compare
|
👍 |
|
So a lot of stuff changed that has been breaking tests. The thing that this is current stuck on is packed refs - CircleCI now packs refs, and we expect simple-formatted refs. |
|
Okay: supports packed-refs now. cc @jfirebaugh for the review |
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Fixes
Before:
After:
I think code order is a better default ordering for documentation - this groups, for instance, get and set methods easily.
cc @lucaswoj @jfirebaugh for the review