-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Patch making Plugwise Annatherm preset accept/synch with remote changes and allow events to react II #4311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@p-hagen , thank you for this PR and your work. SendSwitch(const int NodeID, const uint8_t ChildID, const int BatteryLevel, const bool bOn, const double Level, const std::string& defaultname, const int RssiLevel /* =12 */) |
@gizmocuz, I have followed examples of coding for an selector switch in Domoticz code (onkyo, Daikin,PhilipsHue as fe examples) As far as i could tell they all followed the PushAndWaitRxMessage then query the database. I know in the past i tried to work with SendSwitch when i first implemented the preset selector switch , but the only way i managed to get the selector switch to work reliable was with updating the Database. If you can point me to a working example of an selector switch using SendSwitch, I will happily change the code. For all other switches i've added in the past, I use the regular helper functions as they are super easy |
@p-hagen , Sorry about this, totally missed the 'sector switch' .... thought it was a normal switch ;) |
Thanks!! |
No problem...! Thanks for validating I still haven't lost my code stealing..ehhh.. borrowing skills ;) |
Could any of this also have changed the function of "flame_state"? What I see happening now is that flame_state is switched on as soon as the heat pump is started, while in the anna.plugwise.net portal you see that the boiler is off. If I'm correct, flame_state used to be the command to also start the boiler (should the Elga not be capable of heating on its own). If flame_state is now used to signal if the Elga heat pump is operational, is it possible to also signal if the boiler is required? |
Making sure the Anna Preset selector switch now notifies the Event system, allowing Events to react to these changes as well
using m_mainworker.PushAndWaitRxMessage.
Fixed general event handling
Added Logs line to better trace what happens
Added Usage log line to help new user with the Preset handling