Align the directory icons. #173
Conversation
|
Why? |
|
As the screenshots above, the directory icons are not aligned in center with the text, especailly for .git and .vscode folders. |
|
The icons are not aligned because of glyph differences, why would left aligning them make any difference? |
|
If the folder list is long, the directory icons and the text will be not aligned, which cause the bad UX. Adding ("\\.tags" all-the-icons-octicon "tag" :height 1.0 :v-adjust 0.0 :face all-the-icons-blue) |
|
Ah I see what you are trying to do, you are trying to tighten the gap between top and bottom. However, I see the top of the git icon has been clipped. Maybe try playing around with the height a little bit? |
|
No. It couldn't address the issue in my testing. And the bigger height makes the icon bigger than others. Do you have other solution? |
|
Hi, if you still have some concerns, how about add an optional argument |
|
Have you tried setting the height from 1.1 back to 1.0? |
|
Sure. The icon looks smaller than others, and is still not aligned vertically after setting to 1.0. BTW, the most of directory icons are not aligned vertically if you look at carefully. |
That's the problem of mixing multiple fonts of different sizes into one icon font. It's an inherent problem of this package. I think it's futile to individually adjust all of them, there are dozens of tickets in this package that is the result of this technical choice. The ideal solution is to take the SVG sources of these icons, resize all of them, and then replace the icon fonts with these SVG icons. I've been experimenting with this and see how much of a performance impact it will have. Meanwhile, if you want you can keep playing with the text properties until they are perfectly aligned. I'm reluctant to accept any PRs that is not straightly an improvement. |
|
Close it due to #181. |
Align the directory icons.
Before:
After:
