Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containers: Match "Add variable" UI #23606

Closed
Tracked by #23140
fmontes opened this issue Dec 17, 2022 · 0 comments
Closed
Tracked by #23140

Containers: Match "Add variable" UI #23606

fmontes opened this issue Dec 17, 2022 · 0 comments
Assignees
@zulqarnainvd
Labels
QA : Needs Internal QA : Passed Internal Release : 23.02 Team : Lunik
Milestone
2023.02

Comments

@fmontes
Copy link
Member

fmontes commented Dec 17, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

As a UX designer, I want to make sure that the variable popup match the design.

Describe the solution you'd like

To match the Figma design, also when the user click "Add" it should insert the variable and close the popup.

Mock

Figma

image

Acceptance criteria

  • Match the Figma
  • When the user click "Add" it should insert the variable and close the popup.
@fmontes fmontes changed the title Containers: Add variable UI Containers: Match "Add variable" UI Dec 17, 2022
@zulqarnainvd zulqarnainvd self-assigned this Dec 20, 2022
zulqarnainvd added a commit that referenced this issue Dec 20, 2022
@zulqarnainvd
#23606 match figma design and update test case
afbcf9d
zulqarnainvd added a commit that referenced this issue Dec 20, 2022
@zulqarnainvd
#23606 fix font-size issue
1c5a98c
zulqarnainvd added a commit that referenced this issue Dec 23, 2022
@zulqarnainvd
#23606 Containers: Match "Add variable" UI (#23618)
d0ffbea 
* #23606 match figma design and update test case

* #23606 fix font-size issue
@fmontes fmontes closed this as completed Jan 12, 2023
@damen-dotcms damen-dotcms added this to the 2023.02 milestone Feb 1, 2023
@fmontes fmontes mentioned this issue Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zulqarnainvd zulqarnainvd

Labels
QA : Needs Internal QA : Passed Internal Release : 23.02 Team : Lunik
Projects
None yet
Milestone
2023.02
Development

No branches or pull requests
3 participants
@fmontes @zulqarnainvd @damen-dotcms