Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "#16252 format source. Introduce format checker on build. Alte… #16291

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
4 participants
@dsilvam
Copy link
Contributor

commented Mar 27, 2019

…r style … (#16288)"

This reverts commit 05f9082.

@dsilvam dsilvam merged commit 20eb3e6 into master Mar 27, 2019

1 of 2 checks passed

jenkins/tests Build failed
Details
license/cla Contributor License Agreement is signed.
Details

@dsilvam dsilvam deleted the revert-16252 branch Mar 27, 2019


return addressManager.hasWrite(addressId);
}
catch (com.liferay.portal.PortalException pe) {
Contentlet c = APILocator.getContentletAPI()
.find(cinfo.getWorkingInode(), APILocator.getUserAPI().getSystemUser(),
false);
return (c.getStructure().getStructureType()

This comment has been minimized.

Copy link
@codacy-bot
* if {@code expression} is false
*/
public static void checkArgument(boolean expression, @NotNull Object errorMessage) {
com.dotcms.repackage.com.google.common.b

This comment has been minimized.

jgambarios added a commit that referenced this pull request Mar 28, 2019

#16270 now the bulk actions could be get on community edition, but ca… (
#16298)

* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16270 now the bulk actions could be get on community edition, but can just run system workflow actions, rest of them are not allowed without license

* #16270 formatting a bit

jgambarios added a commit that referenced this pull request Mar 28, 2019

#15934 minor refactor for allowing all files (#16297)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #15934 minor refactor for allowing all files

jgambarios added a commit that referenced this pull request Mar 28, 2019

Issue 15935 fire multipart backup (#16294)
* #15935 code almost done to improvements to the wf fire + multipart, missing fixes on unit test

* #15935 fixing issues and fixing unit test

* #15935 fixes and code tested

* #15935 added relationships

* #15935 adding a new mode: working

* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* #15935 now fire action on workflow resource is supporting categories

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #15935 adding support for shorty when finding by identifier on fire action and language fallbacks

jgambarios added a commit that referenced this pull request Apr 2, 2019

Issue 15799 when identifier does not exists throws exception (#16305)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #15799 now when the identifier does not exists return 404, also when the vtl does not exists returns 404

* #15799 removing unused imports

* #15799 feedback and unit test

* #15799 feedback and unit test2

jgambarios added a commit that referenced this pull request Apr 2, 2019

Issue 16230 fushing cache on integrity checker (#16323)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16230 adding flush to the IC

* #16230 flushing all caches

* #16230 removing all cache from integrity checkers

* #16230 removing unnecessary code

jgambarios added a commit that referenced this pull request Apr 5, 2019

Issue 15799 when identifier does not exists throws exception2 (#16328)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #15799 now when the identifier does not exists return 404, also when the vtl does not exists returns 404

* #15799 removing unused imports

* #15799 feedback and unit test

* #15799 feedback and unit test2

* #15799 fixes and unit test

* #15799 doing a refactor

dsilvam added a commit that referenced this pull request Apr 8, 2019

Issue 16301 update ajax action (#16340)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16301 initial work, untested

* #16301 updating remote publisher ajax action

* #16301 updating remote publisher ajax action

* #16301 adding bundle id to bundle view

* #16301 allow a bundle id to be specified

* #16301 remove checkstyle file

* #16301 Integration tests for AjaxDirectorServlet part1

* #16301 handle null bundle owner

* #16301 codacy review

* #16301 codacy and code review feedback

jgambarios added a commit that referenced this pull request Apr 9, 2019

Issue 16263 changes tosupport containerpath onpagerender (#16317)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16263 after the change the file asset container now use just the part on the data-dot-identifier and are not sent twice in the container node in the page rendered

* #16263 the container UUID now has a path instead of id when it is a file asset container

* #16263 dealing with path instead of id when the container is file asset

* #16263 now using the parent path instead of the path itself for the ontainer uuid when it is file asset container

jgambarios added a commit that referenced this pull request Apr 10, 2019

Issue 11969 qa internal review (#16348)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #11969 QA internal and minor fixes

jgambarios added a commit that referenced this pull request Apr 10, 2019

Issue 16026 requiredtag publish (#16362)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16026 when a content with required tags is published, now is ok to do it

jgambarios added a commit that referenced this pull request Apr 11, 2019

Issue 16377 invalid class referenced in dependent jar (#16378)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16377 : Referencing new repackaged version of the conflicting .JAR excluding the no-longer-valid class.

jgambarios added a commit that referenced this pull request Apr 12, 2019

Issue 16359 shorty invalidation2 (#16379)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16310 invalidate shortyId on identifier and content

* #16310 adding to cache

* #16359 adding unit test and changes to invalidate the shorties

jgambarios added a commit that referenced this pull request Apr 12, 2019

Issue 16374 wf it (#16381)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16374 adding multipart fire integration test

* #16374 adding multipart fire integration test

* #16374 adding multipart fire integration test for existing contents

jgambarios added a commit that referenced this pull request Apr 12, 2019

Issue 16263 changes tosupport containerpath onpagerender (#16392)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16263 after the change the file asset container now use just the part on the data-dot-identifier and are not sent twice in the container node in the page rendered

* #16263 the container UUID now has a path instead of id when it is a file asset container

* #16263 dealing with path instead of id when the container is file asset

* #16263 now using the parent path instead of the path itself for the ontainer uuid when it is file asset container

* #16263 adding support for container/content to get the html for a container file asset

* #16263 fix to use the current host when there is not a host in the container id as a path

jgambarios added a commit that referenced this pull request Apr 12, 2019

Issue 16359 shorty invalidation2 (#16387)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16310 invalidate shortyId on identifier and content

* #16310 adding to cache

* #16359 adding unit test and changes to invalidate the shorties

* #16359 fixing an issue when the id is null

erickgonzalez pushed a commit that referenced this pull request Apr 12, 2019

#16257 Escape values with spaces and double quotes for unique content…
… lookup (#16276)

* #16257 Escape values with spaces and double quotes for PP unique content lookup

* #16257 Removed unused imports

* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16257 Generated hash value for indexing unique fields

* #16257 Used local final variables when possible

* #16257 Validation for unique fields using hash value

* #16257 Aux methods to match exiting content moved to PublisherConfig class

jgambarios added a commit that referenced this pull request Apr 23, 2019

Issue 16310 fixing issue shortify (#16415)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16310 fixing an issue when the shorty is not valid on the shortify

* #16310 fixes when the length of the shorty passed is less than 10 to about out of bounds

jgambarios added a commit that referenced this pull request Apr 23, 2019

Issue 16333 vanity urls adding improvements2 (#16413)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16333 : When initializing Vanity URLs upon startup or cache flush, read from DB instead of reading from the ES index as it may be not fully updated yet.

* #16333 adding small changes

* #16333 when the secondary cache is repopulate, the previous elements on the primary cache were orphan, now the elements on the current secondary cache are removed before override the secondary cache

jgambarios added a commit that referenced this pull request May 3, 2019

Issue 16026 requiredtag save keepexistingtags (#16510)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16026 fixes when saving a news with existing tags and adding newones, now are not missing the newones

* #16026 now the setTags is only called on content search

* #16026 unit test for save contentlet with tags CRUD

* #16026 removing unnecessary unit test

jgambarios added a commit that referenced this pull request May 7, 2019

Issue 16026 settags fixes2 (#16530)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16026 added fixes for the bulk actions and new strategy for the set tags

jgambarios added a commit that referenced this pull request May 8, 2019

Issue 16538 unable save versionspanish (#16542)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16538 fix for saving pages on diff langs

jgambarios added a commit that referenced this pull request May 8, 2019

Issue 16538 unable save versionspanish (#16542)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16538 fix for saving pages on diff langs

(cherry picked from commit f21ef0c)

jgambarios added a commit that referenced this pull request May 22, 2019

Issue 16594 more logging contentlet validation (#16596)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16594 : Adding more useful logging to Contentlet validation operations. Replacing deprecated code. Adding Javadoc.

* #16594 : Referencing correct variable.

* #16594 : Adding more error logging. Using Sneak to get the new Content Type object through the new Content Type API.

* #16594 : Adding more error logging.

jgambarios added a commit that referenced this pull request May 29, 2019

Issue velocity actionlet clean (#16398)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* Prototype of the Script Actionlet

* Added more strategies to read files from diff sources

* some fixes and changes

* Simpler version of the ScriptActionlet as a Velocity Action let that by now just support a script and velocity code

* Removed unnecessary stuff, enhacements and fixes for the Velocity and Message Actionlet

* Adding changes for unit test for the velocity script actionlet and some minor enhacements to viewtool lang and workflow endpoint

* Added unit test for Save Content Action let and fixes for Set Value

* Added the large test and minor refactor based on the feedback

* Latest changes to support last message and some of the feedback done

* Avoid out of bounds exception

* Applying feedback

jgambarios added a commit that referenced this pull request Jun 4, 2019

Issue minor public encryptor refactor (#16500)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* minor refactoring to include mostly the original excepcion'

jgambarios added a commit that referenced this pull request Jun 14, 2019

Issue 16688 file container zero content (#16689)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16688 adding the ability to support container_code.vtl

jgambarios added a commit that referenced this pull request Jun 19, 2019

Issue 16562 personalization (#16687)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16562 upgrade task to add the personalization column as key on the multi tree

* #16562 adding changes for multitree api changes to support the personalization field

* #16562 adding the logic to see when a page has personalization for a persona

* #16562 Added the Resource to get the personalization persona page

* #16562 added the copy of the containers page for a specific personalization

* #16562 Now the user can clone the page containers to personalize the content per persona

* #16562 adding the remove personalization for page containers

* #16562 minor changes and improvements over the personalization container stuff

* #16562 unit test for new stuff and refactored on the MultTreeAPI

* #16562 unit test for the personalization db change

* #16562 Adding the support for the page render edit mode personalization

* #16562 Added a prototype of a variant based on the container persona tag

* #16562 minor changes over the listener

* #16562 refactoring to handle the personalization more in parse runtime

* #16562 new approach for personalization on multi tree working on BE editmode and FE

* #16562 minor fixes

jgambarios added a commit that referenced this pull request Jun 19, 2019

Issue 16562 fixing multitree test (#16751)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16562 fixing an unit test

jgambarios added a commit that referenced this pull request Jun 19, 2019

Issue 16562 fixing cache issues (#16759)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16562 fixes for cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.