Skip to content

Exception on pref get without a preference name #420

@tlmii

Description

@tlmii

Same issue could, theoretically, occur with set header, though I think it is gated separately.

System.ArgumentNullException: String reference not set to an instance of a String. (Parameter 's')
   at System.Text.Encoding.GetBytes(String s)
   at System.Text.UTF8Encoding.UTF8EncodingSealed.GetBytes(String s)
   at Microsoft.HttpRepl.Telemetry.Sha256Hasher.HashInFormat(SHA256 sha256, String text) in /_/src/Microsoft.HttpRepl.Telemetry/Sha256Hasher.cs:line 22
   at Microsoft.HttpRepl.Telemetry.Sha256Hasher.Hash(String text) in /_/src/Microsoft.HttpRepl.Telemetry/Sha256Hasher.cs:line 17
   at Microsoft.HttpRepl.Telemetry.Events.PreferenceEvent.SanitizePreferenceName(String preferenceName) in /_/src/Microsoft.HttpRepl/Telemetry/Events/PreferenceEvent.cs:line 25
   at Microsoft.HttpRepl.Telemetry.Events.PreferenceEvent..ctor(String getOrSet, String preferenceName) in /_/src/Microsoft.HttpRepl/Telemetry/Events/PreferenceEvent.cs:line 15
   at Microsoft.HttpRepl.Commands.PrefCommand.GetSetting(IShellState shellState, HttpState programState, DefaultCommandInput`1 commandInput) in /_/src/Microsoft.HttpRepl/Commands/PrefCommand.cs:line 200
   at Microsoft.HttpRepl.Commands.PrefCommand.ExecuteAsync(IShellState shellState, HttpState programState, DefaultCommandInput`1 commandInput, ICoreParseResult parseResult, CancellationToken cancellationToken) in /_/src/Microsoft.HttpRepl/Commands/PrefCommand.cs:line 160
   at Microsoft.Repl.Commanding.CommandWithStructuredInputBase`2.ExecuteAsync(IShellState shellState, TProgramState programState, TParseResult parseResult, CancellationToken cancellationToken) in /_/src/Microsoft.Repl/Commanding/CommandWithStructuredInputBase.cs:line 213
   at Microsoft.HttpRepl.Telemetry.TelemetryCommandWrapper.ExecuteAsync(IShellState shellState, HttpState programState, ICoreParseResult parseResult, CancellationToken cancellationToken) in /_/src/Microsoft.HttpRepl/Telemetry/TelemetryCommandWrapper.cs:line 39
   at Microsoft.Repl.Commanding.DefaultCommandDispatcher`2.ExecuteCommandInternalAsync(IShellState shellState, CancellationToken cancellationToken) in /_/src/Microsoft.Repl/Commanding/DefaultCommandDispatcher.cs:line 154
   at Microsoft.Repl.Commanding.DefaultCommandDispatcher`2.ExecuteCommandAsync(IShellState shellState, CancellationToken cancellationToken) in /_/src/Microsoft.Repl/Commanding/DefaultCommandDispatcher.cs:line 137

Metadata

Metadata

Assignees

No one assigned

    Labels

    5.0-dashPotential final items for 5.0bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions