-
Notifications
You must be signed in to change notification settings - Fork 315
Test | Addressing Net5 runtime issues #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cheenamalhotra
merged 25 commits into
dotnet:master
from
JRahnama:net5-tests-compatibility
Mar 2, 2021
Merged
Test | Addressing Net5 runtime issues #880
cheenamalhotra
merged 25 commits into
dotnet:master
from
JRahnama:net5-tests-compatibility
Mar 2, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraith2
reviewed
Jan 15, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TestFixtures/SQLSetupStrategy.cs
Outdated
Show resolved
Hide resolved
Wraith2
reviewed
Jan 15, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs
Outdated
Show resolved
Hide resolved
Wraith2
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny suggestions otherwise LGTM.
cheenamalhotra
approved these changes
Jan 20, 2021
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlExceptionTest.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
approved these changes
Jan 29, 2021
Wraith2
reviewed
Feb 2, 2021
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlExceptionTest.cs
Outdated
Show resolved
Hide resolved
Wraith2
reviewed
Feb 5, 2021
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlExceptionTest.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlNotificationTest/SqlNotificationTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/RandomStressTest/Randomizer.cs
Outdated
Show resolved
Hide resolved
johnnypham
reviewed
Feb 23, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataStreamTest/DataStreamTest.cs
Outdated
Show resolved
Hide resolved
/azp run CI-Ub16-SQL17L-TR, CI-Win10-AzureSQLDB, CI-Win10-SQL17W, CI-Win10-SQL19W-Fx48-Core31, CI-Win10-SQL19W-ManagedSNI, CI-Win10-SQL19W-TR |
Azure Pipelines successfully started running 6 pipeline(s). |
cheenamalhotra
approved these changes
Mar 1, 2021
johnnypham
approved these changes
Mar 1, 2021
karinazhou
reviewed
Mar 1, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/CspProviderExt.cs
Show resolved
Hide resolved
karinazhou
reviewed
Mar 1, 2021
karinazhou
reviewed
Mar 1, 2021
karinazhou
reviewed
Mar 1, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TestFixtures/SQLSetupStrategy.cs
Show resolved
Hide resolved
karinazhou
reviewed
Mar 1, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/Common/AsyncDebugScope.cs
Outdated
Show resolved
Hide resolved
karinazhou
reviewed
Mar 2, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlNotificationTest/SqlNotificationTest.cs
Outdated
Show resolved
Hide resolved
karinazhou
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to test the driver against Net5, runtime caught some unobserved issues/warnings
is introduced to get the operating system but the API is not known in lower versions.
In some cases such as overridable methods usage I have moved the method inside a concrete method and called it from there and that made the driver to compile and run. I am eager to hear all comments about the changes to improve them and make them better.
Thanks
Update:
I noticed some improvement opportunities in our test lab:
SqlNotificationTest was using
ManualResetEvent
I have changed them to use ManualResetEventSlim. Reasoning to do so:there are small differences such as kernel related behavior and blocking the thread which may have better effect on our test lab.