Skip to content

Update SDK to pick up incremental Razor source generator #33833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2021
Merged

Update SDK to pick up incremental Razor source generator #33833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a65da9
Update SDK to pick up incremental Razor source generator
captainsafia Jun 25, 2021
001a80b
Bump SDK version again
captainsafia Jun 26, 2021
ee8e5e0
Merge branch 'main' into safia/sdk-irsg
captainsafia Jun 26, 2021
da18b16
Update SDK to pick up another bug fix
captainsafia Jun 27, 2021
8c9fe67
Update to resolve issues with building test assets
captainsafia Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"sdk": {
"version": "6.0.100-preview.7.21324.2"
"version": "6.0.100-preview.7.21327.2"
},
"tools": {
"dotnet": "6.0.100-preview.7.21324.2",
"dotnet": "6.0.100-preview.7.21327.2",
"runtimes": {
"dotnet/x64": [
"2.1.27",
Expand Down
1 change: 0 additions & 1 deletion src/Components/benchmarkapps/Wasm.Performance/TestApp/Wasm.Performance.TestApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
Clien caching isn't part of our performance measurement, so we'll skip it.
-->
<BlazorCacheBootResources>false</BlazorCacheBootResources>
<UseRazorSourceGenerator>false</UseRazorSourceGenerator>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this anymore. I fixed the root cause in #33456 anyways.

</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion src/Components/test/testassets/BasicTestApp/BasicTestApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

<!-- Project supports more than one language -->
<BlazorWebAssemblyLoadAllGlobalizationData>true</BlazorWebAssemblyLoadAllGlobalizationData>
<UseRazorSourceGenerator>false</UseRazorSourceGenerator>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With local and CI-based runs of ./build.sh in src/Components I'm not seeing #31023 anymore so I think we're good here.

If that turns out not to be the case, we can revisit.

</PropertyGroup>

<PropertyGroup Condition="'$(TestTrimmedApps)' == 'true'">
Expand Down