Update SDK to pick up incremental Razor source generator #33833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've been trying to update the SDK :/ |
|
@BrennanConroy Ack. I'm doing this to shake out any issues with the incremental source generator that I just merged. I mostly want to verify that the builds for projects with Razor/CSHTML are fine. |
Pilchie
added
the
area-infrastructure
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
captainsafia
commented
Jun 28, 2021
| Clien caching isn't part of our performance measurement, so we'll skip it. | ||
| --> | ||
| <BlazorCacheBootResources>false</BlazorCacheBootResources> | ||
| <UseRazorSourceGenerator>false</UseRazorSourceGenerator> |
There was a problem hiding this comment.
We don't need this anymore. I fixed the root cause in #33456 anyways.
captainsafia
commented
Jun 28, 2021
|
|
||
| <!-- Project supports more than one language --> | ||
| <BlazorWebAssemblyLoadAllGlobalizationData>true</BlazorWebAssemblyLoadAllGlobalizationData> | ||
| <UseRazorSourceGenerator>false</UseRazorSourceGenerator> |
There was a problem hiding this comment.
With local and CI-based runs of ./build.sh in src/Components I'm not seeing #31023 anymore so I think we're good here.
If that turns out not to be the case, we can revisit.
pranavkm
approved these changes
Jun 28, 2021
ghost
added this to the
halter73
added a commit
that referenced
this pull request
Jun 28, 2021
)" This reverts commit 86ea8e0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.