Skip to content

Conversation

ShreyasJejurkar
Copy link
Contributor

@ShreyasJejurkar ShreyasJejurkar commented Aug 19, 2023

  1. Enable Accelerated builds for all projects. Read more here => https://github.com/dotnet/project-system/blob/main/docs/build-acceleration.md

@ghost ghost added needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically community-contribution Indicates that the PR has been added by a community member labels Aug 19, 2023
@ghost
Copy link

ghost commented Aug 19, 2023

Thanks for your PR, @ShreyasJejurkar. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ShreyasJejurkar ShreyasJejurkar changed the title local development build improvements Local development build improvements Aug 19, 2023
@ShreyasJejurkar ShreyasJejurkar marked this pull request as ready for review August 20, 2023 09:02
@ShreyasJejurkar ShreyasJejurkar requested review from wtgodbe and a team as code owners August 20, 2023 09:02
@ShreyasJejurkar
Copy link
Contributor Author

Failure looks unrelated to this change!

@ShreyasJejurkar ShreyasJejurkar changed the title Local development build improvements Enable build acceleration Aug 22, 2023
@mkArtakMSFT mkArtakMSFT added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Aug 22, 2023
@ghost
Copy link

ghost commented Aug 22, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@adityamandaleeka
Copy link
Member

Thanks @ShreyasJejurkar. It would be great to see a before/after comparison showing the impact of this on build time.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 28, 2023

Agree the failure looks unrelated - were you able to get data on whether this speeds things up in VS?

@ShreyasJejurkar
Copy link
Contributor Author

@wtgodbe in local testing, it does speed up build perf. I will post some screenshot here about that, please give me some more time. Sorry having some office work, got engaged in that.

@ghost
Copy link

ghost commented Sep 5, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 5, 2023
@RussKie
Copy link
Contributor

RussKie commented Sep 15, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@RussKie RussKie enabled auto-merge (squash) September 15, 2023 05:59
@RussKie RussKie removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 15, 2023
@RussKie RussKie merged commit 6df29ac into dotnet:main Sep 15, 2023
@ghost ghost added this to the 9.0-preview1 milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants