Skip to content

Enable build acceleration #50205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Enable build acceleration #50205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0eda3d
Enable Accelerated builds for all projects
ShreyasJejurkar Aug 19, 2023
46d2d9f
Disable build acceleration for installer projects
ShreyasJejurkar Aug 20, 2023
c10b770
1. Remove newly added build.props file.
ShreyasJejurkar Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<Project>
<Import Project="eng\Common.props" />

<PropertyGroup>
<AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
</PropertyGroup>

<PropertyGroup>
<!-- $(RepoRoot) is normally set globally and Arcade overrides it to ensure a trailing slash. -->
<RepoRoot Condition=" '$(RepoRoot)' == '' OR !HasTrailingSlash('$(RepoRoot)') ">$(MSBuildThisFileDirectory)</RepoRoot>
Expand Down
6 changes: 6 additions & 0 deletions src/Installers/Debian/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,11 @@
<!-- All installers are shipping assets. -->
<IsShipping>true</IsShipping>
<IsPackable>true</IsPackable>

<!--
For installers project, build acceleration may not work correctly.
Read more here => https://github.com/dotnet/project-system/blob/main/docs/build-acceleration.md#limitations
-->
<AccelerateBuildsInVisualStudio>false</AccelerateBuildsInVisualStudio>
</PropertyGroup>
</Project>
6 changes: 6 additions & 0 deletions src/Installers/Rpm/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,11 @@
<!-- RPM files are platform-specific and should be named appropriately. -->
<RpmArch Condition=" '$(TargetArchitecture)' == 'x64' ">x64</RpmArch>
<RpmArch Condition=" '$(TargetArchitecture)' == 'arm64' ">aarch64</RpmArch>

<!--
For installers project, build acceleration may not work correctly.
Read more here => https://github.com/dotnet/project-system/blob/main/docs/build-acceleration.md#limitations
-->
<AccelerateBuildsInVisualStudio>false</AccelerateBuildsInVisualStudio>
</PropertyGroup>
</Project>
9 changes: 9 additions & 0 deletions src/Installers/Windows/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,13 @@
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" />

<Import Project="Wix.props" Condition="'$(MSBuildProjectExtension)' == '.wixproj'" />

<PropertyGroup>
<!--
For installers project, build acceleration may not work correctly.
Read more here => https://github.com/dotnet/project-system/blob/main/docs/build-acceleration.md#limitations
-->
<AccelerateBuildsInVisualStudio>false</AccelerateBuildsInVisualStudio>
</PropertyGroup>

</Project>