Skip to content

remove TokenCompletionContext, make CompletionContext non-abstract #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2023
Merged

remove TokenCompletionContext, make CompletionContext non-abstract #2126

merged 1 commit into from
Mar 29, 2023

Conversation

adamsitnik
Copy link
Member

Explanation: TokenCompletionContext does not extend CompletionContext with any new API

fixes #1929

@adamsitnik adamsitnik requested a review from jonsequitur March 29, 2023 15:17
@adamsitnik adamsitnik enabled auto-merge (squash) March 29, 2023 15:28
@adamsitnik adamsitnik merged commit 7e84513 into dotnet:main Mar 29, 2023
@adamsitnik adamsitnik deleted the CompletionContext branch March 29, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsequitur jonsequitur jonsequitur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider differentiating these two *CompletionContext scenarios using fewer public types
2 participants
@adamsitnik @jonsequitur