Reduce Reflection usage #2662
Merged
Reduce Reflection usage #2662
+45
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d are used only by the unit test project
…mmand to VersionOption: - make it clear when Reflection is used - don't load and compile Assembly type when RootCommand is used for the first time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently writing the Threat Model for S.CL and when describing the Reflection usage I've realized that:
ArgumentBuilderandOptionBuildercan be removed, as they are no longer used by the product (I suspect they were used by some of the libs we have removed recently)RootCommanddoes not need to define anAssemblyfield, which forces the JIT to load and compile more types whenRootCommandis used for the first time. Since we care about startup perf, I've moved it toVersionOptionAction, which will be lazy used when neededcommand-line-api/src/System.CommandLine/VersionOption.cs
Lines 36 to 38 in 0b4618b