Re-add default value on ProcessTerminationTimeout #2672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpatkisson
changed the title
adamsitnik
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Great catch! Big thanks for providing a detailed bug report and the fix @mpatkisson !
mpatkisson
deleted the
resolve-operationcanceledexception-not-thrown-without-config-in-async-apps
branch
adamsitnik
pushed a commit
to adamsitnik/command-line-api
that referenced
this pull request
Aug 28, 2025
Co-authored-by: Michael Atkisson <mpatkisson@triptacular.com>
adamsitnik
pushed a commit
to adamsitnik/command-line-api
that referenced
this pull request
Aug 28, 2025
Co-authored-by: Michael Atkisson <mpatkisson@triptacular.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update re-introduces a default 2s value to
InvocationConfiguration.ProcessTerminationTimeoutto ensure thatOperationCanceledExceptionis thrown onCtrl+Cin apps using async commands. See detailed bug report #2671 for analysis and reproduction steps.