Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Move Core-Setup to 1.0.2 LTS version #338

Merged
merged 3 commits into from
Sep 30, 2016
Merged

Move Core-Setup to 1.0.2 LTS version #338

merged 3 commits into from
Sep 30, 2016

Conversation

gkhanna79
Copy link
Member

@ramarag @weshaggard @ericstj PTAL

Wont be merged until dotnet/coreclr#7296 is merged.

CC @leecow

@gkhanna79 gkhanna79 added * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) blocking-servicing labels Sep 23, 2016
@dnfclas
Copy link

dnfclas commented Sep 23, 2016

Hi @gkhanna79, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@weshaggard
Copy link
Member

LGTM

@gkhanna79
Copy link
Member Author

@dotnet-bot test this please

ellismg
ellismg reviewed Sep 28, 2016
View reviewed changes
build_projects/shared-build-targets-utils/DependencyVersions.cs Outdated
public static readonly string CoreCLRVersion = "1.0.2";
public static readonly string JitVersion = "1.0.2";
// TODO: Update these for consuming servicing version of CoreCLR packages
// Also, update CoreCLR package referenced at /Users/gkhanna/Github/gkhanna79/core-setup/pkg/projects/Microsoft.NETCore.App/project.json

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@gkhanna79
Copy link
Member Author

Fixes https://github.com/dotnet/core-setup/issues/402

@gkhanna79 gkhanna79 removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 30, 2016
@gkhanna79 gkhanna79 merged commit 2afae60 into dotnet:release/1.0.0 Sep 30, 2016
@dagood dagood mentioned this pull request Oct 2, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ellismg ellismg ellismg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

blocking-servicing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gkhanna79 @dnfclas @weshaggard @ellismg